Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Accounting base64 encoding for resources size validation #1803

Merged
merged 6 commits into from
Nov 28, 2024
Merged

🐛 Accounting base64 encoding for resources size validation #1803

merged 6 commits into from
Nov 28, 2024

Conversation

rishigupta1599
Copy link
Contributor

@rishigupta1599 rishigupta1599 commented Nov 28, 2024 •
edited
Loading

Resources which were greater than 25 MB in size we want to skip them in resource array as they might fail to upload, but when we upload we do base64 encoding which increases the size but while validation we were not accounting for increase in size due to encoding.
Base64 has 33-37% increase in content size so we are reducing max size check by that much factor

@rishigupta1599 rishigupta1599 requested a review from a team as a code owner November 28, 2024 07:07
@rishigupta1599 rishigupta1599 changed the title Fixing logic of resources with size > 25MB not skipping Accounting bas64 encoding for resources size validation Nov 28, 2024
@rishigupta1599 rishigupta1599 changed the title Accounting bas64 encoding for resources size validation Accounting base64 encoding for resources size validation Nov 28, 2024
@rishigupta1599 rishigupta1599 merged commit c0cafd3 into master Nov 28, 2024
36 checks passed
@rishigupta1599 rishigupta1599 deleted the fixing_large_resource_check branch November 28, 2024 08:40
@rishigupta1599 rishigupta1599 changed the title Accounting base64 encoding for resources size validation 🐛 Accounting base64 encoding for resources size validation Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninadbstack ninadbstack ninadbstack approved these changes

@Amit3200 Amit3200 Amit3200 approved these changes

@shantanuk-browserstack shantanuk-browserstack Awaiting requested review from shantanuk-browserstack shantanuk-browserstack is a code owner automatically assigned from percy/percy-product-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rishigupta1599 @Amit3200 @ninadbstack